JAVA-5774 Allow all property types for Filter.regex() #1619
Conversation
|
I'm not sure I fully understand the usecase could you please add some test cases? That should help. |
jenssuhr
force-pushed
the
MIRA-5774-regex-restrictions
branch
from
75bd37c to
b9f235b
Compare
Sure, I can do that |
|
Oops, forgot that renaming the source branch closes the PR |
…ter on a non-String (value class) property
|
I've added an example for filtering on a property with a value class type, but it would also be useful for data classes with a custom codec that serialize into a string. |
|
@jenssuhr thanks for the clarification. I'm tempted to say this change maybe too niche for users. With the explicit String type users can rationalize what will happen during encoding. I am concerned that if it is widened out to any type users may not fully understand what will happen during encoding and if they even need a custom codec. |
|
@rozza Fair point, I think this PR can be closed. If the |
While it makes some sense to only allow the
regexfunction on String properties, this also precludes using it with properties that wrap the String in a value class.To allow for that use case, I think it would make sense to relax the property type and allow anything there.